From 1a83aaeb67d50f321fbf4caf0d402bbacebd6857 Mon Sep 17 00:00:00 2001
From: Laurent Bercot <ska-skaware@skarnet.org>
Date: Sat, 10 Jan 2015 16:12:57 +0000
Subject:  Bugfix: unixmessage_sender_free didn't close all the pending fds

---
 src/libunixonacid/unixmessage_receiver_free.c |  1 +
 src/libunixonacid/unixmessage_sender_free.c   | 21 +++++++++------------
 src/libunixonacid/unixmessage_unput.c         |  1 +
 3 files changed, 11 insertions(+), 12 deletions(-)

(limited to 'src')

diff --git a/src/libunixonacid/unixmessage_receiver_free.c b/src/libunixonacid/unixmessage_receiver_free.c
index 74654d0..d9d575e 100644
--- a/src/libunixonacid/unixmessage_receiver_free.c
+++ b/src/libunixonacid/unixmessage_receiver_free.c
@@ -1,5 +1,6 @@
 /* ISC license. */
 
+#include <skalibs/cbuffer.h>
 #include <skalibs/stralloc.h>
 #include <skalibs/djbunix.h>
 #include <skalibs/unixmessage.h>
diff --git a/src/libunixonacid/unixmessage_sender_free.c b/src/libunixonacid/unixmessage_sender_free.c
index 797220c..965b1a7 100644
--- a/src/libunixonacid/unixmessage_sender_free.c
+++ b/src/libunixonacid/unixmessage_sender_free.c
@@ -4,24 +4,21 @@
 #include <skalibs/diuint.h>
 #include <skalibs/stralloc.h>
 #include <skalibs/genalloc.h>
+#include <skalibs/djbunix.h>
 #include <skalibs/unixmessage.h>
 
 void unixmessage_sender_free (unixmessage_sender_t *b)
 {
-#ifdef SKALIBS_HASANCILAUTOCLOSE
+  unsigned int i = genalloc_s(diuint, &b->offsets)[b->head].right ;
+  unsigned int n = genalloc_len(int, &b->fds) ;
+  for (; i < n ; i++)
   {
-    diuint *offsets = genalloc_s(unsigned int, &b->offsets) ;
-    unsigned int n = genalloc_len(unsigned int, &b->offsets) ;
-    int *fds = genalloc_s(int, &b->fds) ;
-    unsigned int nfds = genalloc_len(int, &b->fds) ;
-    for (; b->head < n ; b->head++)
-    {
-      register unsigned int last = b->head+1 < n ? offsets[b->head+1].right : nfds ;
-      register unsigned int i = offsets[b->head].right ;
-      for (; i < last ; i++) if (fds[i] >= 0) fd_close(fds[i]) ;
-    }
-  }
+    register int fd = genalloc_s(int, &b->fds)[i] ;
+    if (fd < 0) fd_close(-(fd+1)) ;
+#ifdef SKALIBS_HASANCILAUTOCLOSE
+    else fd_close(fd) ;
 #endif
+  }
   genalloc_free(diuint, &b->offsets) ;
   genalloc_free(int, &b->fds) ;
   stralloc_free(&b->data) ;
diff --git a/src/libunixonacid/unixmessage_unput.c b/src/libunixonacid/unixmessage_unput.c
index 48d46b5..63e94b8 100644
--- a/src/libunixonacid/unixmessage_unput.c
+++ b/src/libunixonacid/unixmessage_unput.c
@@ -19,5 +19,6 @@ int unixmessage_unput_and_maybe_drop (unixmessage_sender_t *b, int drop)
   }
   b->data.len = start->left ;
   genalloc_setlen(int, &b->fds, start->right) ;
+  genalloc_setlen(diuint, &b->offsets, n-1) ;
   return 1 ;
 }
-- 
cgit v1.2.3