From 1d03235d0682e00b5cd4edaab0108ca755ab90af Mon Sep 17 00:00:00 2001
From: Laurent Bercot <ska-skaware@skarnet.org>
Date: Sun, 24 Feb 2019 14:54:28 +0000
Subject:  Build as PIC by default

---
 NEWS             |  3 +++
 configure        | 15 ++-------------
 doc/upgrade.html |  5 +++++
 3 files changed, 10 insertions(+), 13 deletions(-)

diff --git a/NEWS b/NEWS
index 3933097..9f950d7 100644
--- a/NEWS
+++ b/NEWS
@@ -9,6 +9,9 @@ GNU C, not C99.) The AVLTREEN_DECLARE_AND_INIT() macro should be
 used instead.
  - New functions: env_dump(), mk?temp(), autosurf(), autosurf_name()
  - mkdir_unique() removed. (Duplicate functionality with mkdtemp.)
+ - ancilautoclose and nbwaitall sysdeps removed.
+ - New header: skalibs/posixishard.h
+ - Static libraries are now PIC by default.
 
 
 In 2.7.0.0
diff --git a/configure b/configure
index 984e77e..b70def5 100755
--- a/configure
+++ b/configure
@@ -34,7 +34,7 @@ Dependencies:
 Optional features:
   --disable-shared              do not build shared libraries [enabled]
   --disable-static              do not build static libraries [enabled]
-  --enable-all-pic              build everything as PIC [enabled iff toolchain builds PIE]
+  --disable-all-pic             do not build static libraries as PIC [enabled]
   --enable-slashpackage[=ROOT]  assume /package installation at ROOT [disabled]
 
 $package options:
@@ -235,7 +235,7 @@ sysdepdir='$prefix/lib/$package/sysdeps'
 sysdeps=
 shared=true
 static=true
-allpic=detect
+allpic=true
 slashpackage=false
 ipv6=true
 select=false
@@ -384,20 +384,9 @@ if test -z "$target" ; then
 fi
 echo "  ... $target"
 
-if test $allpic = detect ; then
-  echo "Checking whether we need to build everything as PIC..."
-  if $CC_AUTO $CPPFLAGS_AUTO $CPPFLAGS $CPPFLAGS_POST $CFLAGS_AUTO $CFLAGS $CFLAGS_POST -dM -E - < /dev/null | grep -qF __PIE__ ; then
-    allpic=true
-    echo "  ... yes"
-  else
-    allpic=false
-    echo "  ... no"
-  fi
-fi
 if $allpic ; then
   tryflag CFLAGS_AUTO -fPIC
 fi
-
 tryflag CFLAGS_AUTO -std=c99
 tryflag CFLAGS -fomit-frame-pointer
 tryflag CFLAGS_AUTO -fno-exceptions
diff --git a/doc/upgrade.html b/doc/upgrade.html
index 924ebc4..551b548 100644
--- a/doc/upgrade.html
+++ b/doc/upgrade.html
@@ -26,6 +26,11 @@
 function.) </li>
  <li> New functions: <tt>env_dump()</tt>, <tt>mk?temp()</tt>,
 <tt>autosurf()</tt>, <tt>autosurf_name()</tt> </li>
+ <li> The ancilautoclose and nbwaitall sysdeps have been removed. </li>
+ <li> New header: <tt>skalibs/posixishard.h</tt> </li>
+ <li> <tt>libskarnet.a</tt> now builds as PIC by default no matter
+the toolchain's settings. Use the <tt>--disable-all-pic</tt> configure
+option to build static libraries as non-PIC. </li>
 </ul>
 
 <h2> in 2.7.0.0 </h2>
-- 
cgit v1.2.3