Clean up and modernize librandom.

 Correct random number generation has historically been
suprisingly painful to achieve. There was no standard,
every system behaved in a subtly different way, and there
were a few userland initiatives to get decent randomness,
all incompatible of course.
 The situation is a bit better now, we're heading towards
some standardization. The arc4random() series of functions
is a good API, and available on a lot of systems -
unfortunately not Linux, but on Linux the new getrandom()
makes using /dev/random obsolete.

 So I removed the old crap in librandom, dropped EGD support,
dropped dynamic backend selection, made a single API series
(random_* instead of goodrandom_* and badrandom_*), added
an arc4random backend and a getrandom backend, and defaulted
to /dev/urandom backed up by SURF in the worst case. This
should be much smaller and logical. However, it's a major
API break, so the skarnet.org stack will be changed to
adapt.

1 files changed, 3 insertions, 3 deletions

diff --git a/src/libstddjb/sauniquename.c b/src/libstddjb/sauniquename.c
index 5a6ad83..ddf47ec 100644
--- a/src/libstddjb/sauniquename.c
+++ b/src/libstddjb/sauniquename.c
@@ -12,7 +12,7 @@ int sauniquename (stralloc *sa)
   unsigned int base = sa->len ;
   int wasnull = !sa->s ;
 
-  if (!stralloc_readyplus(sa, TIMESTAMP + UINT_FMT + 131)) return -1 ;
+  if (!stralloc_readyplus(sa, TIMESTAMP + UINT_FMT + 131)) return 0 ;
   sa->s[base] = ':' ;
   timestamp(sa->s + base + 1) ;
   sa->s[base + 1 + TIMESTAMP] = ':' ;
@@ -20,9 +20,9 @@ int sauniquename (stralloc *sa)
   sa->len += uint_fmt(sa->s + sa->len, getpid()) ;
   sa->s[sa->len++] = ':' ;
   if (sagethostname(sa) == -1) goto err ;
-  return 0 ;
+  return 1 ;
 
 err:
   if (wasnull) stralloc_free(sa) ; else sa->len = base ;
-  return -1 ;
+  return 0 ;
 }