summaryrefslogtreecommitdiff
path: root/src/libstddjb
diff options
context:
space:
mode:
authorLaurent Bercot <ska-skaware@skarnet.org>2023-06-23 14:44:54 +0000
committerLaurent Bercot <ska@appnovation.com>2023-06-23 14:44:54 +0000
commit56066894b7d14f71aeba8379f0d6e5961dee733e (patch)
treed2ad93979e0ca63acdadfdc03384d4f1fc106d53 /src/libstddjb
parent7a9e5888e9b721452869e35b83e74b36844d3cfd (diff)
downloadskalibs-56066894b7d14f71aeba8379f0d6e5961dee733e.tar.xz
Apply fixes suggested by jjk
Signed-off-by: Laurent Bercot <ska@appnovation.com>
Diffstat (limited to 'src/libstddjb')
-rw-r--r--src/libstddjb/buffer_get.c9
-rw-r--r--src/libstddjb/buffer_getv.c5
-rw-r--r--src/libstddjb/slurpn.c2
3 files changed, 9 insertions, 7 deletions
diff --git a/src/libstddjb/buffer_get.c b/src/libstddjb/buffer_get.c
index fbc0de3..6fe394d 100644
--- a/src/libstddjb/buffer_get.c
+++ b/src/libstddjb/buffer_get.c
@@ -1,12 +1,13 @@
/* ISC license. */
-#include <errno.h>
+#include <stddef.h>
+
+#include <skalibs/allreadwrite.h>
#include <skalibs/buffer.h>
ssize_t buffer_get (buffer *b, char *s, size_t len)
{
size_t w = 0 ;
- int r = buffer_getall(b, s, len, &w) ;
- return r == -1 ? errno == EPIPE ? (errno = 0, w) : -1 :
- !r ? (errno = EWOULDBLOCK, -1) : w ;
+ ssize_t r = unsanitize_read(buffer_getall(b, s, len, &w)) ;
+ return r < 0 ? r : w ;
}
diff --git a/src/libstddjb/buffer_getv.c b/src/libstddjb/buffer_getv.c
index 280a3b4..ab637a3 100644
--- a/src/libstddjb/buffer_getv.c
+++ b/src/libstddjb/buffer_getv.c
@@ -1,6 +1,7 @@
/* ISC license. */
-#include <sys/uio.h>
+#include <stddef.h>
+
#include <skalibs/allreadwrite.h>
#include <skalibs/buffer.h>
@@ -8,5 +9,5 @@ ssize_t buffer_getv (buffer *b, struct iovec const *v, unsigned int n)
{
size_t w = 0 ;
ssize_t r = unsanitize_read(buffer_getvall(b, v, n, &w)) ;
- return r <= 0 ? r : w ;
+ return r < 0 ? r : w ;
}
diff --git a/src/libstddjb/slurpn.c b/src/libstddjb/slurpn.c
index c9c5c11..ee5157f 100644
--- a/src/libstddjb/slurpn.c
+++ b/src/libstddjb/slurpn.c
@@ -16,7 +16,7 @@ int slurpn (int fd, stralloc *sa, size_t max)
for (;;)
{
ssize_t r ;
- size_t n = max && sa->len + N > max ? max - sa->len : N ;
+ size_t n = max && sa->len - sabase + N > max ? max - (sa->len - sabase) : N ;
if (!n) { errno = ENOBUFS ; goto err ; }
if (!stralloc_readyplus(sa, n)) break ;
r = fd_read(fd, sa->s + sa->len, n) ;