diff options
author | Laurent Bercot <ska-skaware@skarnet.org> | 2020-04-29 19:08:19 +0000 |
---|---|---|
committer | Laurent Bercot <ska-skaware@skarnet.org> | 2020-04-29 19:08:19 +0000 |
commit | 038082c425c40037a28111934dfb5037edbcad8c (patch) | |
tree | 33a5af0aabf64334b93eb0c60158954dc2baf415 /src/libstddjb/stralloc_shrink.c | |
parent | 20568ed2f00772e0a927ed21b7aa437c92ab8707 (diff) | |
download | skalibs-038082c425c40037a28111934dfb5037edbcad8c.tar.xz |
Fix alloc_realloc UB
void ** does not exist: the address of a generic pointer is not
properly defined (different pointer types may have different
representations). So, alloc_realloc cannot exist as is without UB.
Fortunately, it's not supposed to be used in the skalibs programming
style, and skalibs itself only uses it in two places
(stralloc_ready_tuned and stralloc_shrink) where the pointer is a
char *.
So we just fix the UB by making alloc_realloc() take a char **,
and it's only defined for that pointer type.
Nothing to see here folks, nothing happened at all.
Diffstat (limited to 'src/libstddjb/stralloc_shrink.c')
-rw-r--r-- | src/libstddjb/stralloc_shrink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libstddjb/stralloc_shrink.c b/src/libstddjb/stralloc_shrink.c index a372084..0dceca2 100644 --- a/src/libstddjb/stralloc_shrink.c +++ b/src/libstddjb/stralloc_shrink.c @@ -7,7 +7,7 @@ int stralloc_shrink (stralloc *sa) { if (sa->a > sa->len) { - if (!alloc_re((void **)&sa->s, sa->a, sa->len)) return 0 ; + if (!alloc_re(&sa->s, sa->a, sa->len)) return 0 ; sa->a = sa->len ; } return 1 ; |