summaryrefslogtreecommitdiff
path: root/src/libstddjb/child_spawn.c
diff options
context:
space:
mode:
authorLaurent Bercot <ska-skaware@skarnet.org>2019-06-16 09:01:54 +0000
committerLaurent Bercot <ska-skaware@skarnet.org>2019-06-16 09:01:54 +0000
commitda84f235ef985883c79066204ee838717aacd41a (patch)
treeb7a8dd8931814b9ad9a02bf848020645c0146cc1 /src/libstddjb/child_spawn.c
parentdae816d196ca006cb0e820de1d468e551129f220 (diff)
downloadskalibs-da84f235ef985883c79066204ee838717aacd41a.tar.xz
child_spawn*: make sure posix_spawn() doesn't clobber pipes with dup2+close
Diffstat (limited to 'src/libstddjb/child_spawn.c')
-rw-r--r--src/libstddjb/child_spawn.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/libstddjb/child_spawn.c b/src/libstddjb/child_spawn.c
index 964e4e2..58bbfc8 100644
--- a/src/libstddjb/child_spawn.c
+++ b/src/libstddjb/child_spawn.c
@@ -77,14 +77,14 @@ pid_t child_spawn (char const *prog, char const *const *argv, char const *const
}
e = posix_spawn_file_actions_init(&actions) ;
if (e) goto errattr ;
- if (n >= 2)
+ if (n >= 2 && p[1][0])
{
e = posix_spawn_file_actions_adddup2(&actions, p[1][0], 0) ;
if (e) goto erractions ;
e = posix_spawn_file_actions_addclose(&actions, p[1][0]) ;
if (e) goto erractions ;
}
- if (n)
+ if (n && p[0][1] != 1)
{
e = posix_spawn_file_actions_adddup2(&actions, p[0][1], 1) ;
if (e) goto erractions ;