From f7c2e436ed0144d09cff0e3ac90f510a47f0aeac Mon Sep 17 00:00:00 2001 From: Laurent Bercot Date: Wed, 12 Jul 2017 18:22:55 +0000 Subject: Add s6_svc_lock_take() and s6_svc_lock_release() Allows fixing a race condition in s6-rc-init. s6-supervise also creates event/ before supervise/ so that locking the servicedir ensures event/ can be used. --- src/libs6/deps-lib/s6 | 1 + src/libs6/s6_svc_lock_take.c | 28 ++++++++++++++++++++++++++++ 2 files changed, 29 insertions(+) create mode 100644 src/libs6/s6_svc_lock_take.c (limited to 'src/libs6') diff --git a/src/libs6/deps-lib/s6 b/src/libs6/deps-lib/s6 index ace5a05..5acb672 100644 --- a/src/libs6/deps-lib/s6 +++ b/src/libs6/deps-lib/s6 @@ -26,6 +26,7 @@ s6_accessrules_uidgid_cdb.o s6_accessrules_uidgid_fs.o s6_supervise_lock.o s6_supervise_lock_mode.o +s6_svc_lock_take.o s6_svc_ok.o s6_svc_write.o s6_svc_writectl.o diff --git a/src/libs6/s6_svc_lock_take.c b/src/libs6/s6_svc_lock_take.c new file mode 100644 index 0000000..57830c0 --- /dev/null +++ b/src/libs6/s6_svc_lock_take.c @@ -0,0 +1,28 @@ +/* ISC license. */ + +#include +#include +#include +#include +#include + +int s6_svc_lock_take (char const *dir) +{ + size_t dirlen = strlen(dir) ; + int fdlock ; + char lock[dirlen + sizeof(S6_SUPERVISE_CTLDIR) + 6] ; + memcpy(lock, dir, dirlen) ; + memcpy(lock + dirlen, "/" S6_SUPERVISE_CTLDIR, sizeof(S6_SUPERVISE_CTLDIR) + 1) ; + if ((mkdir(lock, S_IRWXU) < 0) && (errno != EEXIST)) return -1 ; + memcpy(lock + dirlen + sizeof(S6_SUPERVISE_CTLDIR), "/lock", 6) ; + fdlock = open_create(lock) ; + if (fdlock < 0) return -1 ; + if (coe(fdlock) < 0 || lock_ex(fdlock) < 0) + { + int e = errno ; + fd_close(fdlock) ; + errno = e ; + return -1 ; + } + return fdlock ; +} -- cgit v1.2.3